Make cachedKeyDecoder configurable #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think making keyDecoder configurable is better, where you can set a null key decoder that does nothing. |
|
hm actually, yeah maybe it will be better. I just wanted to hide it from public API |
gfx
approved these changes
Aug 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 16 16
Lines 962 962
Branches 195 196 +1
=======================================
Hits 946 946
Misses 16 16
Continue to review full report at Codecov.
|
gfx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.