Fix unpack skipping when extra fields are present #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is rebased to the 0.5 branch because 0.6 is still in beta. |
There was a problem hiding this comment.
Do you want to specify regular ASCIIEncoding here? There are 2 minor problems:
ASCIIEncoding.Defaultdoes NOT return ASCII encoding in many countriies (but they are usually compatible to ASCII for ascii charactors, so this is really trivial issue becauseString40only contains ascii chars).ASCIIEncodingdoes not exist in WinRT, so this line breaks build.
SinceString40has ASCII charactors only, so you can useEncoding.UTF8.GetBytes(String40)safely here.
|
Thank you for your PR! |
Ensure that unpacker can skip extra fields of type Str8, Bin8, Bin16 and Bin32 which may be present when using PackerCompatibilityOptions.None
webcoyote
force-pushed
the
fix-unpack-skipping
branch
from
6e75d76 to
fd4c1b8
Compare
|
Thanks for the information about WinRT; I've corrected the issue you pointed out and changed ASCII -> UTF8. |
yfakariya
added a commit
that referenced
this pull request
Aug 9, 2015
This commit complements PR #98. ItemsUnpacker also missed ext type handling too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that unpacker can skip extra fields of type Str8, Bin8, Bin16 and Bin32
which may be present when using PackerCompatibilityOptions.None