Support serialisation of .NET 4.5 read only collection interfaces #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oses msgpack#91. - IReadOnlyDictionary<,> - IReadOnlyCollection<> - IReadOnlyList<>
yfakariya
added a commit
that referenced
this pull request
Jul 20, 2015
PR #93 was perfect in terms of abstract type support itself. But there are more considerations about custom types which only implements read only collection interfaces. It requires additional collection serializer hierarchy and additional kinds.
|
Wow, seems I only scratched the surface of what was required for this feature. Thanks for finishing this off. I'll read through your commit and learn some more about the code base. |
|
@drewnoakes Don't worry. I also forgot about them, NUnit found :) Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to close the issue I opened (#91) regarding this feature.
Supported types are:
IReadOnlyDictionary<,>IReadOnlyCollection<>IReadOnlyList<>