Skip to content

fix bad DateTime sample - #355

Merged
yfakariya merged 2 commits into
msgpack:masterfrom
faithandbrave:fix_bad_datetime_sample
Apr 7, 2023
Merged

fix bad DateTime sample#355
yfakariya merged 2 commits into
msgpack:masterfrom
faithandbrave:fix_bad_datetime_sample

Conversation

@faithandbrave

@faithandbrave faithandbrave commented Apr 7, 2023

Copy link
Copy Markdown
Contributor
  1. year format should be yyyy not YYYY
  2. day format should be dd not DD
  3. deserialized DateTime has UTC timezone. The value should convert to local timezone

yfakariya
yfakariya reviewed Apr 7, 2023
View reviewed changes
Comment thread samples/Samples/Sample01_BasicUsage.cs Outdated
@yfakariya
yfakariya merged commit 3417b5e into msgpack:master Apr 7, 2023
@yfakariya

yfakariya commented Apr 7, 2023

Copy link
Copy Markdown
Member

Thank you!

@faithandbrave
faithandbrave deleted the fix_bad_datetime_sample branch April 7, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yfakariya yfakariya yfakariya left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faithandbrave @yfakariya