Update dev certs with effectively infinite expiry - #331
Merged
Conversation
This tool solves a problem that Visual Studio only generates 1-year expiry certs. By this commit, dev-certs will have expiry until 2038. In that time, UWP apps should be replaced completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates development certificates for appx files in unit test projects with effectively infinite expiry (
Int32.MaxValueunix seconds).Although it may be available to set the expiry to more large date like 9999-12-31, there are some systems which have year 2038 problem in my personal experience. In such systems, expiry over 2038 causes certification validation error. So, I selected
Int32.MaxValueunix seconds as expiry.I also ship the simple powershell script to generate a such certificate for later maintenance.