Skip to content

Conversation

@takeshik
Copy link
Contributor

Overview

Concerns

If there are problems, please reject it. This modification may be optimistic.

Remove non-accessible members from the target:
  * Properties which does not have either public getter or setter.
  * Fields which is initonly.
@yfakariya
Copy link
Member

Thank you for your great work, but this patch introduces new issue that read-only collection typed members are not serialized properly. So, I reject your request.
Please run unit tests on your local environment for 0.4 branch, so it will show you that 93 tests will fail by this commit.

Thanks anyway.

yfakariya added a commit that referenced this pull request May 24, 2014
yfakariya added a commit that referenced this pull request May 24, 2014
Signed-off-by: yfakariya <yfakariya@gmail.com>
@takeshik
Copy link
Contributor Author

Thanks for your consideration. I'll submit again a new PR when I solved problems that you mentioned.

And, I'll check and write tests from next time 😉

arigato gozaimashita!

@takeshik
Copy link
Contributor Author

(forgot to close)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants