Fixed issue #37. #38
Merged
Fixed issue #37. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
It seems to be gcc's bug. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58416
|
I tested this code and #43 with gcc in some Linux distributions and clang in Mavericks. For gcc, it was indeed same or even faster to use memcpy instead of simple assignments. However, for clang, the original was 10% faster than the version using memcpy. Since the performance of this part of code is very critical, it might be better to provide two implementations for gcc and clang (or other compilers) separately. What do you think, @redboltz ? |
|
Thanks for testing it. I agree with you. This modification is original from a workaround for gcc's bug. |
|
I realized that GNUC is defined both gcc and clang. We need to find another approach. |
…rator. The memcpy approach is a workaround for gcc's bug. The speed performance on gcc is the same between both approach. But on clang, the memcpy approach is 10% slower than an assignment approach. Hence I added the switching approach code using compiler checked macro. Note: __GNUC__ is defined both gcc and clang. So I use __GNUC__ && !__clang__
redboltz
added a commit
that referenced
this pull request
Dec 16, 2013
redboltz
added a commit
to redboltz/msgpack-c
that referenced
this pull request
Jun 22, 2014
redboltz
added a commit
to redboltz/msgpack-c
that referenced
this pull request
Jul 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to be gcc's bug.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58416