Compile error when include msgpack/adaptor/define.hpp directly.

[redboltz]

See #339 (comment)

When a client code includes msgpack/adaptor/define.hpp directly, compile error occurs. msgpack/adaptor/define.hpp doesn't include enough include files.

[reza-ebrahimi]

@redboltz The error in int.hpp is fixed but some compile errors still exists:

adaptor_base_decl.hpp(49): error C2955: 'msgpack::v1::packer': use of class template requires template argument list
adaptor_base_decl.hpp(23): note: see declaration of 'msgpack::v1::packer'
adaptor_base_decl.hpp(49): error C2988: unrecognizable template declaration/definition
adaptor_base_decl.hpp(49): error C2059: syntax error: '<'

[reza-ebrahimi]

@redboltz Please check your commits compatibility with earlier versions of MSVC compiler such as VS2012 and VS2010.

[redboltz]

@reza-ebrahimi , I updated my commit. It includes MSVC 2010, 2012, 2013, and 2015. All tests passed. Could you check it?

[reza-ebrahimi]

@redboltz Sure, Compile errors returns back to our first state (compiled sample project with VS2015), Error snapshot:

[redboltz]

@reza-ebrahimi, hmm... the errors are not reproduced on my environment MSVC2015.
I added the similar test in the PR. https://github.com/redboltz/msgpack-c/blob/e6f82cf2bbf36f0a5f491444eb064f0a3d25a83e/test/inc_adaptor_define.cpp

Appveyor doesn't report errors neither.

Could you retry the branch on the clean environment? I mean from git clone ....

[redboltz]

@nobu-k, could you check the PR on your environment?

[nobu-k]

Unfortunately, nobody around me had MSVC...

[redboltz]

Thanks, @nobu-k.
@reza-ebrahimi, did you test it? I'm sorry to rush you.

[reza-ebrahimi]

@redboltz Sorry for late response, The problem was exists, I have download cloned zip file directly from repository in github.

So in order of that I have faced with new problem, the problem is when build INSTALL project, it will copies wrong hierarchy of directories in target location, The previous versions copied a directory as following:

msgpack/include
msgpack/lib

so with current version of repository the copied directory was:

include

Yes, only include folder without its parent ("msgpack" folder) have been copied.

[redboltz]

@reza-ebrahimi , thank you for the reply.

Which branch did you test? #464 or master. If you tested master, the problem still exists because I didn't merge #464.

If you testes #464, something wrong...

Here is a command to checkout #464

git checkout -b redboltz-fix_463 master
git pull https://github.com/redboltz/msgpack-c.git fix_463

I also checked the error message that you attached. It is caused by the lack of include file on int.hpp. And I added it on #464 as follows:
https://github.com/msgpack/msgpack-c/pull/464/files#diff-3ae1f69a5ddd808b101c6031e39b5730R14

Could you check include/msgpack/v1/adaptor/int.hpp line 14 on your local file?
That should be #include "msgpack/object.hpp"

https://github.com/redboltz/msgpack-c/blob/fix_463/include/msgpack/v1/adaptor/int.hpp#L14

[reza-ebrahimi]

@redboltz I have checkout master branch, I didn't know that you were not commit changes to master, I'll check it and get back here to report it, so I think the problem solved, Thanks for your effort.

Is there any consideration that you doesn't commit changes to master branch?