POST command should return error, response, body

[roopesh]

It's pretty standard to return at least an error in a callback function. I've modified it locally to give me the error, response, and body. Either way I have to interpret it but this way I have access to the response.statusCode and the body.response.result.

And trying to parse the body regardless of error and always trying to return the data regardless of result doesn't work in failure cases.

[mseminatore]

@roopesh Can you elaborate on your issue a little bit further? All API's take a standard Node-style callback which returns (error, data) to the callback function. Are you asking to return the body instead of the response? And are you asking to return an error or data but not both?

[roopesh]

So when I send in an invalid token I don't get an error object back. In fact the node instance was creating because there wasn't a response in the data. The only way to know what was happening was to get the response and check the statusCode. I could see the 401.

So in my local version I return error, response, and body to interpret the call's output.

[roopesh]

Oops. The node instance was crashing.

[mseminatore]

@roopesh Returning (error, body, response) would be non-standard behavior for a Node library so that is a non-starter. However body is already fully contained within response so only response would need to be returned.

Changing the return parameters to the node-back would be a breaking change to the API and so per semver rules that cannot be considered for 2.x. I will however consider it for 3.x. Please feel free to elaborate on what you'd like to see if it is different than what I just described.

[roopesh]

That works for me. I'll update mine to return response, too, and see if it works.

[roopesh]

That works. I'm now just getting the error, response back from the POST (I'm going to change the GET to the same thing) and I can get to the body from there.

Thank you!

[mseminatore]

@roopesh You are welcome! Hope the library works for your needs.