Skip to content

Accidental bugs#12

Merged
github-learning-lab[bot] merged 2 commits intomasterfrom
bug-fix
May 23, 2019
Merged

Accidental bugs#12
github-learning-lab[bot] merged 2 commits intomasterfrom
bug-fix

Conversation

@github-learning-lab
Copy link
Contributor

Now that your release is finalized, we have a confession to make... somewhere in our recent update, I made a mistake and introduced a bug. Instead of changing the text colors to green, we changed the whole background.

Sometimes GitHub Pages takes a few minutes to update. Your page might not immediately show the recent updates you've made.

image

"Hotfixes", or a quick fix to address a bug in software, are a normal part of development. Oftentimes you'll see application updates whose only description is "bug fixes".

When bugs come up after you release a version, you'll need to address them.

We've already created this branch, pull request, and suggested a fix. The suggested change will be merged into the master branch. Later we will cherry-pick the hotfix commits into the release branch.

Step 12: Approve a hotfix pull request

Submit a hotfix by applying the the suggested change and approving this PR.

⌨️ Activity: Apply the suggestion

  1. Click Commit suggestion
  2. Enter a commit message
  3. Click Commit changes
  4. Approve this pull request

I'll respond below with your next steps

@github-learning-lab github-learning-lab bot requested a review from msdevpt May 23, 2019 16:15
Hotfix

Co-Authored-By: github-learning-lab[bot] <github-learning-lab[bot]@users.noreply.github.com>
Copy link
Owner

@msdevpt msdevpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix back color

@github-learning-lab github-learning-lab bot merged commit f55eeae into master May 23, 2019
@github-learning-lab
Copy link
Contributor Author

Your fix is now on master! This ensures that any new code isn't based on our bug.

Let's backport those changes to the branch with release v1.0.


Go to the next pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants