Skip to content

FIX: Import importlib functions directly #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscheltienne merged 4 commits into from
Sep 27, 2024
Merged

FIX: Import importlib functions directly #68

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a1f2fb
EAFP
scott-huberty Sep 27, 2024
b5b1be4
Revert "EAFP"
scott-huberty Sep 27, 2024
6533cc7
API: import importlib submodules directly
scott-huberty Sep 27, 2024
7b89723
STY: more explicit
scott-huberty Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions template/utils/_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@

from __future__ import annotations

import importlib
from importlib import import_module
from importlib.util import find_spec
from typing import TYPE_CHECKING

if TYPE_CHECKING:
Expand Down Expand Up @@ -54,12 +55,12 @@ def import_optional_dependency(
"""
package_name = _INSTALL_MAPPING.get(name)
install_name = package_name if package_name is not None else name
if importlib.util.find_spec(name) is None:
if find_spec(name) is None:
if raise_error:
raise ImportError(
f"Missing optional dependency '{install_name}'. {extra} Use pip or "
f"conda to install {install_name}."
)
else:
return None
return importlib.import_module(name)
return import_module(name)