Use Ruff implementation of PyDocStyle and isort #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove pydocstyle from dependencies. - Remove pydocstyle from pre-commit yaml - Remove tool.pydocstyle from pyproject.toml - add tool.ruff.pydocstyle - add "D" to the tool.ruff.lint select option, per ruff docs https://docs.astral.sh/ruff/settings/#lintpydocstyle - move 'D100', 'D104', 'D107' from tool.pydocstyle add_ignore to tool.ruff.lint.per-file-ignores - tool.ruff.lint.pydocstyle ignore-decorators expects a list of str, not just a str - add click.group to ignore-decorators so that ruff does not raise an error for the docstring in template.commands.main.run - did NOT port tool.pydocstyle match and match_dir to tool.ruff.lint.pydocstyle, because these parameters dont exist in it and I think these configurations should already be covered by the tool.ruff configurations
mscheltienne
changed the title
Owner
|
Thanks a lot @scott-huberty
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58
pydocstylefrom dependencies.pre-commit.yamltool.pydocstylefrompyproject.tomltool.ruff.pydocstyletopyproject.toml"D"to thetool.ruff.lintselect option, per the ruff docs'D100','D104','D107'from thetool.pydocstyleadd_ignoreoption totool.ruff.lint.per-file-ignorestool.pydocstyle, Thetool.ruff.lint.pydocstyleignore-decoratorsoption expects a list ofstr, not just astrclick.grouptoignore-decoratorsso that ruff does not raise an error for the docstring intemplate.commands.main.run(alternatively we could just make that docstring numpydoc compliant)matchandmatch_diroptions fromtool.pydocstyletotool.ruff.lint.pydocstyle, because these parameters dont exist intool.ruff.lint.pydocstyle, and I think these configurations should already be covered by thetool.ruffconfigurationspre-committo thetestoptional-dependencies.