error when building on arm64 MacBook

[jwatte]

Note that there exists a fix for building on M1:
google/cpu_features#211

Also, this module is broken. The cause of the breakage (upstream or not) doesn't really matter -- unless you're saying "I never plan on fixing this," keeping the issue open helps the community understand what's going on.

Finally, I predict this will become more of a pressing issue now that Apple has stopped selling x64 MacBook Pros entirely, AND this module is a dependency of the electron installer builders.

[mscdex]

I'm not keen on having to patch dependencies like this because I'm not familiar with the cpu_features codebase (let alone macs), so I'm not really qualified to say whether the changes in one PR or another is correct (there are multiple PRs now to add M1 support in cpu_features, all delayed for various reasons).

[jwatte]

That's fair, but I propose the issue is kept open until the problem no longer exists.
One way or another, the upstream will presumably pick one of the fixes ...

[lxe]

@mscdex looks like you've fixed all the build issues for M1 Macs, but I'm not seeing the new commits published to npm. Would you mind getting a new version out? Thanks!

[starzou]

@mscdex Hello, Are there new plans?

[mscdex]

AFAIK there is still no M1 support upstream. The only Apple-related fixes that I originally floated and were eventually made upstream (which I pulled in awhile back) were for macOS x86.

[bompi88]

@mscdex A new version is now available: https://github.com/google/cpu_features/releases/tag/v0.7.0

[technicalpickles]

It took me a minute to realize the dependency is bundled in deps/cpu_features. I tried grabbing the tarball and replacing the directory, but it looks like it's more involved than that.

[mscdex]

I've landed cpu_features v0.7.0 in the master branch. Everyone feel free to give it a whirl and let me know how it works for you.

[mscdex]

I'm going to assume the aforementioned upgrade fixed things. If not, let me know.

[ckortekaas]

@mscdex I'm afraid after upgrading to ssh 1.8.0 which brings in cpu-features 0.3 I started getting "dyld missing symbol called" in my jest integration tests and webpack compilation. This is on a Macbook Pro M1 Max with MacOS 12.3 and Node 16.14.2. I'm happy to run any debug commands locally that might help. For now, I've pinned ssh back to 1.7.0. Thanks for your hard work on these libraries 🙇‍♂️

[mscdex]

@ckortekaas If you're getting them from ssh2, then please create an issue in that repo.