Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rule_valid an attribute of Holding, not Rule #26

Closed
mscarey opened this issue Jun 18, 2019 · 0 comments
Closed

make rule_valid an attribute of Holding, not Rule #26

mscarey opened this issue Jun 18, 2019 · 0 comments

Comments

@mscarey
Copy link
Owner

mscarey commented Jun 18, 2019

The rule_valid and decided attributes of Rule aren't very helpful when adding Rules together. Maybe it's time for a separate class called a Holding that represents the relationship between an Opinion and a Rule. The Holding class could have the rule_valid and decided attributes as well as the text selector showing which part of the Opinion text is the basis for the Holding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant