Skip to content

STL vectors in LAPJV C++ implementation#135

Merged
ms609 merged 13 commits intomainfrom
lapjv-update
Aug 22, 2025
Merged

STL vectors in LAPJV C++ implementation#135
ms609 merged 13 commits intomainfrom
lapjv-update

Conversation

@ms609
Copy link
Owner

@ms609 ms609 commented Jul 30, 2025

@codecov
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.05%. Comparing base (254f9f3) to head (b32d8b2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   99.04%   99.05%           
=======================================
  Files          37       37           
  Lines        2630     2641   +11     
=======================================
+ Hits         2605     2616   +11     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ms609 ms609 added the before-release To be closed before next release label Aug 22, 2025
@github-actions
Copy link

Performance benchmark results

Call Status Change Time (ms)
ClusteringInfoDistance(tr200) ⚪ NSD -0.32% 470 →
476, 470
ClusteringInfoDistance(tr50) ⚪ NSD 0.22% 369 →
367, 370
LAPJV(test2000) 🟢 Faster! 26.79% 181 →
131, 133
LAPJV(test40) 🟠 Slower 🙁 -8.41% 0.0143 →
0.0149, 0.0158
LAPJV(test400) 🟢 Faster! 20.34% 3.07 →
2.44, 2.45
MutualClusteringInfo(tr200) ⚪ NSD -1.52% 464 →
470, 513
MutualClusteringInfo(tr50) ⚪ NSD -0.8% 495 →
495, 503
PathDist(postTrees) ⚪ NSD -4.72% 3.56 →
3.87, 3.67
PhylogeneticInfoDistance(tr200) 🟠 Slower 🙁 -16.36% 329 →
379, 383
PhylogeneticInfoDistance(tr50) 🟠 Slower 🙁 -5.48% 320 →
336, 340
RobinsonFoulds(tr200) ⚪ NSD 0.58% 2.82 →
2.78, 2.83
RobinsonFoulds(tr200) ⚪ NSD 0.72% 2.5 →
2.48, 2.48
RobinsonFoulds(tr50) ⚪ NSD 0.08% 4.16 →
4.09, 4.18

@github-actions
Copy link

Performance benchmark results

Call Status Change Time (ms)
ClusteringInfoDistance(tr200) ⚪ NSD -0.01% 472 →
474, 471
ClusteringInfoDistance(tr50) 🟣 ~same -2.2% 361 →
367, 371
LAPJV(test2000) 🟢 Faster! 25.53% 179 →
134, 133
LAPJV(test40) ⚪ NSD -3.1% 0.0145 →
0.0149, 0.015
LAPJV(test400) 🟢 Faster! 19.02% 3.06 →
2.49, 2.46
MutualClusteringInfo(tr200) ⚪ NSD 3.84% 516 →
469, 523
MutualClusteringInfo(tr50) 🟠 Slower 🙁 -5.37% 493 →
505, 522
PathDist(postTrees) ⚪ NSD -4.59% 3.53 →
3.67, 3.7
PhylogeneticInfoDistance(tr200) 🟠 Slower 🙁 -15.7% 329 →
381, 380
PhylogeneticInfoDistance(tr50) 🟠 Slower 🙁 -5.26% 323 →
338, 341
RobinsonFoulds(tr200) ⚪ NSD 2.28% 2.87 →
2.77, 2.83
RobinsonFoulds(tr200) ⚪ NSD 4.47% 2.58 →
2.43, 2.49
RobinsonFoulds(tr50) ⚪ NSD 1.41% 4.28 →
4.16, 4.35

@ms609 ms609 merged commit c76bfe0 into main Aug 22, 2025
10 of 14 checks passed
@ms609 ms609 deleted the lapjv-update branch August 22, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

before-release To be closed before next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant