Fix delegation on Ruby 2.7 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (*args, **kwargs)-delegation does not work on Ruby 2.7.
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 82 83 +1
=========================================
+ Hits 82 83 +1
Continue to review full report at Codecov.
|
|
@eregon , |
|
@taichi-ishitani No worry. Do you have any suggestion how to improve the article to be clearer? It seems at least a few people got confused by it. |
|
Thank you for this fix @eregon ! I will make a release that includes this |
|
Thanks! |
|
@eregon I've just released v1.3.4 to rubygems, which includes this PR. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(*args, **kwargs)-delegation does not work on Ruby 2.7.See https://eregon.me/blog/2019/11/10/the-delegation-challenge-of-ruby27.html#ruby-3-style-delegation
and https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/#a-compatible-delegation for more details.
Addresses #45 (comment)
and properly fixes #44.
Also fixes jwt/ruby-jwt#396 and in general many SimpleCov usages.
@taichi-ishitani I wonder, was https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ confusing? It intends to say "use ruby2_keywords;
(*args, **kwargs)-delegation does not work on Ruby 2.7". But maybe it needs to be clarified further?