Fix update check for custom repositories

[kingsleyadam]

Currently if AUTOUPDATE='no' and CHECKUPDATE='yes' the script doesn't respect the GIT_OWNER and BRANCHNAME variables while setting the UPSTREAM_GIT_URL. Instead it reverts to the default owner of mrworf and branchname of master.

Move the setter of UPSTREAM_GIT_URL to plexupdate.sh as it relies on config variables.

[kingsleyadam]

I have a fix for this but my repo is further ahead of this one due to my pending slack integration. I can submit a pull request if the other is approved.

[demonbane]

I just looked at your repo to see the code and noticed that #230 is your first PR, so congrats!

A few quick suggestions for saving yourself a lot of aggravation when contributing to projects (from personal experience):

• Try to always keep your fork's master in sync with upstream
• Make any changes on a topic branch
• Open PRs with the upstream project rather than doing a PR on your own project, and then sending a PR for master to upstream
• If you're still working on the code and just want to get some more people looking at it, add [WIP] to the description so we know it's not ready to merge yet
• Git is really good at merging potentially conflicting changes, so don't be afraid to have two different PRs going at the same time

[kingsleyadam]

Thanks for the tips. I realized my mistake right after I merged into my own master. I'm not quite used to working in forked branches so this is good to know. I reverted my commits, this adds new commits which isn't pretty. If you'd rather I scrap the fork and start over I can. There's not too many changes.