Skip to content

fix(hardening): enhance hook to catch single-quoted path literals (#3939) #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrveiss merged 1 commit into from
Apr 8, 2026
Merged

fix(hardening): enhance hook to catch single-quoted path literals (#3939) #3968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autobot-infrastructure/shared/scripts/hooks/pre-commit-hardcoded-values
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ check_hardcoded_paths() {
fi

# Detect bare /opt/autobot, /tmp/autobot, /var/lib/autobot path literals (both single and double quotes)
if echo "$line" | grep -qE '["'"'"'](?:/opt/autobot|/tmp/autobot|/var/lib/autobot)'; then
if echo "$line" | grep -qE "[\"'](/opt/autobot|/tmp/autobot|/var/lib/autobot)"; then
local path_val
path_val=$(echo "$line" | grep -oE '["'"'"'](?:/opt/autobot|/tmp/autobot|/var/lib/autobot)[^"'"'"']*["'"'"']' | head -1)
path_val=$(echo "$line" | grep -oE "[\"'](/opt/autobot|/tmp/autobot|/var/lib/autobot)[^\"']*[\"']" | head -1)
echo -e "${RED}VIOLATION${NC} $file:$line_num"
echo " Hardcoded AutoBot file path: $path_val"
echo -e " ${CYAN}Fix: Use config.path.base_dir from ssot_config or os.environ.get('AUTOBOT_BASE_DIR', '/opt/autobot')${NC}"
Expand Down
Loading