Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

23 changes: 0 additions & 23 deletions autobot-frontend/src/composables/useVncControls.ts

This file was deleted.

23 changes: 0 additions & 23 deletions autobot-slm-frontend/src/composables/useVncControls.ts

This file was deleted.

14 changes: 14 additions & 0 deletions changelog/unreleased/14907-vnc-controls-shim-cleanup.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
type: chore
scope: frontend
issue: 14907
pr: 0
---
`useVncControls` was already consolidated into one implementation (`autobot-plugins/vnc`,
#12931/#12653) — #14907's AC1 named the wrong target package (`@autobot/ui`), which is the only
reason it read as unmet. The two app-local files were thin re-export shims with zero callers
(#12978 had already migrated `DesktopInterface.vue` onto the shared copy directly, orphaning
them); removed both, plus the regression test whose entire subject was the shim (asserting it
re-exported the same function object as the canonical package) — the fork it guarded against is
now structurally impossible with one implementation, not two. `docs/adr/008` updated so its
citation of the two shim files' line numbers doesn't go stale.
8 changes: 5 additions & 3 deletions docs/adr/008-frontend-shared-code-boundary.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,11 @@ By contrast, the two items that *were* the same capability twice converged
cleanly:

- `useVncControls` existed in three places; #12931 gave the shared copy an
injected transport and #12978 reduced the two app copies to re-export shims
(`autobot-frontend/src/composables/useVncControls.ts:13-21`,
`autobot-slm-frontend/src/composables/useVncControls.ts:13-21`).
injected transport and #12978 reduced the two app copies to re-export shims.
Once confirmed callerless in both apps (their migration onto the shared copy
had already left them orphaned), the shims themselves were removed — #14907
— so `autobot-plugins/vnc/src/composables/useVncControls.ts` is now the only
file, not a shim pointing at one.
- The `@autobot/ui` components carry no backend knowledge at all, so both apps
consume them unchanged and supply their own design tokens.

Expand Down
Loading