Repository navigation
fix(ci): correct the dispatch-watchdog pin left stale by the runner move (#15310) - #15329
Merged
Merged
Conversation
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No new hardcoded values of either class — Known backlog in |
…hotfix-15311-watchdog-pin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Dev_new_guihas been red since 2026-08-30 09:22, and every open PR inherits it. Three PRs (#15321, #15327, #15328) all showpython-suite shard 5/12failing — the same shard, on unrelated changes, which is the signature of a base failure rather than three coincidences.Base runs confirm it:
python-suite shard 5/12python-suite shard 5/12ffc37c6f9c(#15311) merged at 09:22:01.The failure:
That test pins the classifier against the real workflow tree, and its comment records
code-quality.ymlas one of "the three workflows named in the falseno runner availablestatus" — i.e. GitHub-hosted at the time it was written. #15311 movedcode-quality.ymlandenforce-precommit.ymlonto the self-hosted runners deliberately (#15310), so the classifier now answers correctly and the expectation is what went stale.This is the narrow case where correcting the assertion rather than the implementation is the fix: the tree changed on purpose, and the pin was left behind by that change.
What Changed
repo_tests/ci_dispatch_watchdog_test.py—code-quality.ymlandenforce-precommit.ymlmove to the "is self-hosted" side of the pin, with the reason and the date recorded inline.ci.ymlandfrontend-required-context.ymlstay asserted as not-self-hosted, deliberately. Keeping both sides is the point: a classifier that answered "self-hosted" for everything would satisfy the two positive assertions on their own, so the negative ones are what give the test its power.enforce-precommit.ymlwas not previously named on either side. It is now, because it is now self-hosted and an unnamed workflow is exactly how this pin drifted in the first place.Verification
No repo code executed. I replicated the classifier's question as data over
.github/workflows/*.yml— does any job declare a self-hosted runner — and checked each of the five names the pin asserts:resolvedfrontend-test.ymlcode-quality.ymlenforce-precommit.ymlci.ymlfrontend-required-context.ymlAll five agree. (The scan also finds
marker-tests.ymlself-hosted; the pin does not name it, and I have not added it — it is outside what this test was written to guard and adding names on a red-base hotfix is scope I would rather not take.)ast.parsepasses. CI is the judge of the test itself.Model Used
Claude Opus 5
Refs #15310 — this repairs a pin left stale by that issue's runner move; it does not change the runner configuration itself.