refactor(user-management): move byte-identical base_service to autobot_shared (#12647)

[mrveiss]

Refs #12647, part of #12645. First step of the user_management de-fork — the one file with no drift to reconcile. The issue stays open.

Thinking Path

#12647's difficulty is semantic drift: 25 shared-but-divergent files, with real behavioural differences in user_service, rbac_middleware and the models. Its own recommendation is to sub-step, starting with models/base + base_service.

Measuring that sub-step first changed its size:

$ diff autobot-backend/.../services/base_service.py autobot-slm-backend/.../services/base_service.py
(0 diff lines — byte-identical)

$ diff .../models/base.py .../models/base.py
64 diff lines

The issue lists base_service as 6 diff lines; it is now 0. So half of sub-step (a) is a move with nothing to reconcile — no drift, no feature union to decide, no risk of losing either side's behaviour. Its imports are uuid, dataclasses, sqlalchemy and autobot_shared.logging_manager — nothing backend-specific, so it is portable as-is.

models/base.py (64 diff lines) is left alone: that one carries the declarative-base question this issue and #12645 both flag, and it is the decision I should not make unilaterally.

What Changed

• autobot_shared/user_management/ created as the consolidation target tech-debt(backend): de-fork the whole user_management package — forked across both backends with real drift #12647 names, with base_service.py moved in verbatim.
• Each backend keeps a re-export shim at the original path, so all 12 existing importers are untouched. The fork is removed, not the callers — same pattern as auth_rbac re-exporting is_admin_role (tech-debt(auth): hand-rolled role == "admin" checks reject superadmin that require_role() admits — convert and gate the class #12948).

Verification

$ python3 -m pytest autobot_shared/user_management/base_service_test.py -q
6 passed in 2.18s

$ python3 -m pytest autobot_shared/ -q
1137 passed in 37.28s

$ python3 -m flake8 (shared package + both shims)
(clean)

import smoke: user_management.services.{base_service,user_service,organization_service}  3/3

The tests assert both shims resolve to the same class objects, not merely equivalent ones:

assert module.BaseService is BaseService
assert a.BaseService is b.BaseService

That identity check is the point. Two same-named classes are not interchangeable — the trap #12913 fixed for CircuitState and #12932 records for the memory graph — so a "de-fork" that left two equivalent-but-distinct classes would reintroduce exactly the defect this umbrella exists to remove.

Why the issue stays open

This is 1 of 25 divergent files, deliberately the easiest. What remains is the actual work: models/base.py (64 lines, gated on the declarative-base decision), rbac_middleware.py (331), database.py (440), config.py (241), user_service.py (111), and the rest — each needing drift reconciled under the issue's "union of features, zero loss" contract.

The value here is establishing the target package and the shim pattern, so subsequent moves are mechanical rather than architectural.

Model Used

claude-opus-5

[github-actions]

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!