Repository navigation
fix(test): repair slm sweep run-phase order-rot + never-run files (#11798) - #11831
Merged
Merged
Conversation
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Applied Black, isort, and autoflake to match code-quality checks. Triggered by workflow auto-fix-formatting.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11798
Thinking Path
With collection fixed by #11794, the run phase showed 105 failures + 36 errors: never-run files (real-load treatment), runtime
sys.modulesclobbering, and per-file/sweep-order rot. Fixed in 5 incremental commits by cluster, polluter-side first, using the established patterns (real-load prologues, snapshot/restore, #9780 parent-attr binding).What Changed
sso_secrets/sso_e2etests real-loaded (real sqlalchemy+aiosqlite, encryption service w/ test key, legacy vault path); ldap3-decorated tests get declared-dep env skips.test_sso_auth.pyin-function permanent stubbing → snapshot/restore helper (file now 15/15 solo, was 1/15);monitoringpathless squat → hollow real-__path__package converged on one shared stub; forced saml enum stub under existing rollback.main_ensure_local_node_testloading the WRONG main.py (repo root,parentsbug),jwks_verifier_testsilently replaced by a MagicMock parent auto-attr in sweeps,test_scimmutating the REALfastapi.responses.JSONResponse.sso_secrets._legacy_retrieveswallowed decryption failures when the legacy table is the PRIMARY store — corruption masqueraded as "no secret"; now strict-raises.oidc_token_cacheraised through its documented "Redis down → cache miss" contract, breaking token verification/logout — new_redis_or_none()degrades all 3 sites (9 in-sweep TypeErrors → 0).Verification
105 failed / 1111 passed / 36 errors→ 1226 passed / 3 justified skips / 0 failed / 0 errors (agent AND independent re-run identical, 57s). Collection 1229/0;tests/services/321/1 intact. flake8 clean on every touched file.Model Used
Claude Fable 5 (subagent: general-purpose)