Repository navigation
fix(test): repair orchestration checkpoint-resumer rot + workflow_memory state bleed (#11754) - #11788
Merged
Merged
Conversation
…ory state bleed (#11754)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11754
Thinking Path
Five pre-existing orchestration failures (baselined during #6828). Two root causes: the #6827 refactor renamed the checkpoint delegation seam (
_checkpoint_manager→_checkpoint_resumer) and three spies still pointed at the deleted attribute; and the process-global circuit-breaker singleton accumulated failures fromexecution_modes_test.py, opening theworkflow_step_executionbreaker so two workflow_memory tests hitCircuitBreakerOpenErrorin group runs (confirmed with a minimal 2-file repro).What Changed
orchestration/workflow_executor_checkpoint_test.py: 3 spies re-pointed toexecutor._checkpoint_resumer.save— the behavioral assertions were already correct against the delegation seam.orchestration/conftest.py: autouse fixture callingget_circuit_breaker_manager().reset_all_circuit_breakers()(the established reset seam) before every orchestration test — no reordering, no flaky marks; every test starts with breakers CLOSED.Verification
tests/orchestration/ + orchestration/ + services/mesh_brain/) 713 passed, 0 failed; polluter pair 60 passed (agent). Independent re-run: the three repaired files 63 passed.Model Used
Claude Fable 5 (subagent: general-purpose)