Skip to content

fix(infra): repair import-dead shared/scripts CLIs — missing imports + phantom modules (#11761) - #11780

Merged
mrveiss merged 1 commit into
Dev_new_guifrom
issue-11761
Jul 15, 2026
Merged

mrveiss merged 1 commit into
Dev_new_guifrom
issue-11761

Conversation

@mrveiss

@mrveiss mrveiss commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Closes #11761

Thinking Path

All 6 remaining autobot-infrastructure/shared/scripts/ CLIs died at import (phantom utils/constants modules that never existed in the directory, plus missing stdlib/dep imports). Repair pattern follows the merged #11765 secrets_manager.py fix exactly: standalone-ness preserved (zero backend imports), real deps imported top-level, small helpers inlined with canonical-source comments (ports/paths mirror ssot_config/ssot_constants env aliases, env-overridable).

What Changed

Per script: log_aggregator (inline mode-only ServiceRegistry + formatter), deployment_rollback (inline TimingConstants + TCP/HTTP health registry + missing yaml), metrics_collector (registry + missing psutil/yaml), backup_manager (trimmed registry + Enum), zero_downtime_deploy (TimingConstants + registry + missing yaml/aiohttp), deploy_autobot (missing logging + DeploymentMode enum registry). Internal scripts.backup_manager cross-import preserved and now clean.

Verification

  • All 7 scripts (6 fixed + secrets_manager): --help exit 0 — agent matrix AND independent re-run by main session; py_compile + flake8 clean.
  • Inlined registry smoke-tested live on this box: mode detection, redis URL build, check_all_services_health return real results.
  • Invoker grep (ansible/workflows/Makefiles/package.json/shell/docs): none reference these CLIs — kept per never-delete rule, now healthy for operator use.

Discovery filed: #11779 — zero_downtime_deploy blue-green path calls two never-defined methods (pre-existing runtime rot, out of import-health scope).

Model Used

Claude Fable 5 (subagent: general-purpose)

@github-actions

Copy link
Copy Markdown
Contributor

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!

@mrveiss
mrveiss merged commit ffc2469 into Dev_new_gui Jul 15, 2026
32 of 33 checks passed
@mrveiss
mrveiss deleted the issue-11761 branch July 15, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant