Repository navigation
fix(infra): repair import-dead shared/scripts CLIs — missing imports + phantom modules (#11761) - #11780
Merged
Conversation
…+ phantom modules (#11761)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
21 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11761
Thinking Path
All 6 remaining
autobot-infrastructure/shared/scripts/CLIs died at import (phantomutils/constantsmodules that never existed in the directory, plus missing stdlib/dep imports). Repair pattern follows the merged #11765secrets_manager.pyfix exactly: standalone-ness preserved (zero backend imports), real deps imported top-level, small helpers inlined with canonical-source comments (ports/paths mirrorssot_config/ssot_constantsenv aliases, env-overridable).What Changed
Per script:
log_aggregator(inline mode-only ServiceRegistry + formatter),deployment_rollback(inline TimingConstants + TCP/HTTP health registry + missingyaml),metrics_collector(registry + missingpsutil/yaml),backup_manager(trimmed registry +Enum),zero_downtime_deploy(TimingConstants + registry + missingyaml/aiohttp),deploy_autobot(missinglogging+ DeploymentMode enum registry). Internalscripts.backup_managercross-import preserved and now clean.Verification
--helpexit 0 — agent matrix AND independent re-run by main session; py_compile + flake8 clean.check_all_services_healthreturn real results.Discovery filed: #11779 — zero_downtime_deploy blue-green path calls two never-defined methods (pre-existing runtime rot, out of import-health scope).
Model Used
Claude Fable 5 (subagent: general-purpose)