Repository navigation
refactor(orchestration): retire last bare AgentRegistry + canonical capability lookup (#6828) - #11756
Merged
Merged
Conversation
… canonical service + renamed distinct registries (#6828)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Auto-regenerated (py3.14) to match the backend schema so the required verify-generated-types gate passes. Triggered by auto-fix-generated-types.yml.
3 tasks
21 of 23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6828
Thinking Path
Owner green-lit this design refactor today. Wiring map established first (the issue's table had gone stale): the 4-way class rename already landed via #8082/#11430, and the "orphan" claim on
orchestration/agent_registry.pyis false — it feeds the REAL production tool-dispatch seam (chat_workflow/tool_handler.py) plus orchestrator/API callers. This PR delivers the reopened scope's remaining substance, not docs.What Changed
AgentRegistryname (zero-importer compat alias inagent_evolution.py); post-grep exactly 2 class defs remain (AgentRegistryService,AgentRegistryProtocol) — issue AC met.AgentCapabilityLookupProtocol inautobot_shared/agent_registry_protocol.py;AgentCapabilityRegistryis the canonical implementer and now concretely implementsAgentRegistryProtocol.update_specializations— the Protocol's first real implementer, verified end-to-end.get_default_capability_registry()singleton accessor — folded 3 ad-hoc registry constructions onto one instance.GET /api/agent/agents/availablenow merges AI Stack agents with the canonical local registry, optionalcapabilityfilter, and degrades to local-only 200 instead of 503 when AI Stack is down (the one deliberate behavior change; follows bug(agents): /api/agents/status 503 in single_user — agent registries are PG-gated, no unified runtime source #10511 precedent; no frontend consumers — grep-verified; covered by test).Verification
Follow-up (orphans left tracked, not deleted):
AgentEvolutionTrackerhas a real registry seam now but no scheduler — wire-in issue text provided in #6828 closure;AgentClient/get_agent_clientzero external callers.Model Used
Claude Fable 5 (subagent: general-purpose)