Repository navigation
feat(slm-agent): probe app-level /health for engine state in heartbeat (#11723) - #11749
Merged
Merged
Conversation
#11723) health_collector now issues a short-timeout local HTTP GET to the /health endpoint of app-health-capable services (starting with autobot-tts-worker) and folds engine_degraded/degraded_reason into the discovered-service dict. Non-fatal on any failure. Completes the #11718 pipeline: worker /health -> agent heartbeat -> reconciler engine_degraded_fields -> Service.extra_data -> NodeServicesPanel degraded badge.
mrveiss
enabled auto-merge (squash)
July 15, 2026 11:47
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
#11718 shipped the TTS worker's
engine_degradedhealth field, the reconciler merge point (engine_degraded_fields), and the NodeServicesPanel badge — but the agent only reads systemd state, so the fields never reachService.extra_datain practice. This adds the missing agent-side link.What Changed
autobot-slm-agent/health_collector.py— new_probe_app_health(): for services inAPP_HEALTH_PROBES(currentlyautobot-tts-worker→http://127.0.0.1:8083/health, env-overridable viaSLM_AGENT_TTS_HEALTH_URL/ timeout viaSLM_AGENT_APP_HEALTH_TIMEOUT), issue a short-timeout local GET and foldengine_degraded/degraded_reasoninto the discovered-service dict. stdliburllib(agent stays dependency-free); never raises — any failure returns{}and discovery proceeds.discover_all_services()calls the probe for running services only.health_collector_probe_test.py— 7 tests: unmapped services not probed, degraded/healthy extraction, missing-field / connection-failure / non-JSON all non-fatal, and discovery folds probe output into the service dict.Verification
engine_degraded_fields(svc_data)→Service.extra_data→ NodeServicesPanel badge (tts/secrets: invalid HF token accepted silently — worker falls back to ungated model yet reports healthy, gated engine never deploys #11718, merged).Closes #11723
Model Used
Fable 5 (inline implementation)
Discoveries
#11748 — slm-agent tests invisible to CI (not in testpaths) + version_test.py standalone failures.