Repository navigation
fix(compliance): F541 f-strings + hook executable + browser routes + nginx (#1116, #1086, #1120, #1122) - #1126
Merged
Merged
Conversation
- Add api/browser.py with proxy endpoints to browser worker (172.16.168.25:3000) - Register browser_router in api/__init__.py and main.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add stat + conditional removal task before the symlink creation so idempotency is preserved when sites-enabled contains a plain file instead of a symlink. Add become: yes to symlink task. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four issues fixed across sessions on this branch:
#1116 — F541 f-strings without placeholders (
performance_analyzer.py)fprefix from 9 f-strings with no{...}placeholderssuggestion=in_check_async_violations"description"values in_classify_performance_issueprint()section headers in__main__blockvue_quality_tool.pyviolations already fixed in commit 3ba2abf (Bug: 112 open() calls missing encoding='utf-8' #1085)#1086 — pre-commit-no-direct-redis hook executable bit
100644 → 100755so hook runs after checkout#1120 — SLM browser API routes for BrowserTool
api/browser.pywith proxy endpoints to browser worker (172.16.168.25:3000)browser_routerinapi/__init__.pyandmain.py#1122 — nginx sites-enabled non-symlink fix
stat+ conditional removal before symlink creation inslm_manager/tasks/main.ymlTest Plan
performance_analyzer.pypre-commit-no-direct-redisis executable (mode 755)Closes #1116
Closes #1086
Closes #1120
Closes #1122
🤖 Generated with Claude Code