Skip to content

fix(deploy): rewrite -r ../requirements.txt to code_source so root runtime deps install on deploy (#11135) - #11237

Merged
mrveiss merged 1 commit into
Dev_new_guifrom
issue-11135
Jul 7, 2026
Merged

mrveiss merged 1 commit into
Dev_new_guifrom
issue-11135

Conversation

@mrveiss

@mrveiss mrveiss commented Jul 7, 2026

Copy link
Copy Markdown
Owner

Thinking Path

#11135 — autobot-backend/requirements.txt:60 is -r ../requirements.txt (repo-root, ~23 runtime deps: paramiko, asyncssh, pypdf, python-docx/pptx, openpyxl, protobuf…). On deploy the sibling ../requirements.txt doesn't exist next to the synced autobot-backend/, and the backend role's post_sync_cmd stripped ^-r lines — so those deps were silently dropped. Same class as #11117, which correctly rewrote -c ../constraints/ to the resolvable code_source path but only stripped -r.

What Changed

In services/role_registry.py the backend post_sync_cmd now:

  • stops stripping -r (grep filters only the editable autobot_shared), and
  • rewrites -r ../requirements.txt → -r {BASE}/code_source/requirements.txt via the same sed that already rewrites -c ../constraints/ (both siblings live in code_source, the full-repo clone).

Root requirements.txt has no nested -c/-r/-e includes, so it resolves cleanly.

Verification

  • Ran the exact grep | sed pipeline on the real requirements.txt: -c ../constraints/shared.txt → code_source/constraints/…, -r ../requirements.txt → /opt/autobot/code_source/requirements.txt, -e autobot_shared stripped (0 residual). ✅
  • tests/services/test_role_registry.py → 17 passed (new regression test asserts the backend post_sync rewrites -r and no longer strips it, and preserves the -c rewrite).
  • black + flake8 clean.
  • Bonus: now that seed_default_roles is insert-only → role_registry changes (e.g. #11069 post_sync_cmd fix) never reach existing SLM DBs #11132 (upsert seeding) is merged, this post_sync_cmd correction will actually reach already-seeded SLM DBs on the next sync.

Review note

⚠️ Deploy-path change — pipeline output is verified locally and mirrors the proven #11117 pattern, but a real code-sync deploy is the ultimate confirmation the ~23 root deps install. Opened for review rather than blind admin-merge.

Model Used

Opus 4.8

Closes #11135

…ot runtime deps install on deploy (was stripped) (#11135)
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant