Repository navigation
fix(ui): MemoryPrivacyPanel showToast call signature — clears 3 vue-tsc errors on base - #10984
Merged
Merged
Conversation
…pe), not an object; clears 3 vue-tsc errors on Dev_new_gui
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
…uth (empty setting names + vault type tag) — clears code-quality on base (#10982 follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
vue-tsc-baselinewas failing on every PR's merge ref with 3TS2345errors inMemoryPrivacyPanel.vue— pre-existing on Dev_new_gui (introduced with the memory-privacy panel, #10554).useNotificationBus().showToastis(message: string, type?: ToastType, duration?), but the panel passed{ message, type }objects.What Changed
Three
showToast({ message: X, type: 'success' })calls →showToast(X, 'success')(positional). No behavior change — the toast now actually renders the intended message/type.Verification
vue-tsc --noEmit -p tsconfig.app.json(faithfulnpm cideps +@autobot/uiresolved): the 3MemoryPrivacyPanel.vueTS2345 errors are gone (0 remaining).Model Used
Opus 4.8