Repository navigation
fix(ui): source Knowledge Manage host dropdown from node registry, not hardcoded VM0-5 (#10505) - #10559
Merged
Conversation
…t hardcoded VM0-5 (#10505)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
The 'Target host' dropdown listed a static VM0-5 fleet (all same co-located IP) from AppConfig.machines, ignoring the real /api/infrastructure/hosts source.
What Changed
SystemKnowledgeManager.vuenow loads hosts via the canonicaluseHostSelectioncomposable (/api/infrastructure/hosts), maps + dedupes by IP, and on an empty co-located source shows only the existing 'All Hosts' option — no VM0-5 template. AppConfig.machines API left intact (this was its only caller).Verification
vue-tsc 0 errors; the empty-source path is handled (parsed-JSON fallback []). Closes #10505.
Model Used
Claude Opus 4.8 (subagent).