Repository navigation
fix(governance): scope branch-cleanup PR search, harden git-guard vs global opts, reconcile mcp-task-manager-server license (#10114, #10434, #10117) - #10464
Merged
Conversation
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Three governance/hooks/license correctness issues from prior discovery rules.
What Changed
gh pr list --search "$n"(over-matches superstrings/body/comments). Added sharedmerged_pr_for_issue()toscripts/lib/branch-guards.sh(per the fix(governance): harden automated branch pruning against deletion race (#10035, #9917) #10112 shared-lib pattern) that filters merged PRs by exactclosingIssuesReferencesmembership; replaced all 3 call sites (branch-cleanup.yml,cleanup-worktrees.sh×2). Verified: superstring9943→reject, exact10032→accept.block-dangerous-commands.shgit guard was bypassed by a global option (git -c x=y checkout). Added a GNU-grep-3.7-safeGIT_GLOBAL_OPTSERE fragment (no fixed-length lookbehind) tolerating repeated-c/-C/--git-dir, wired into all four checkout/switch anchors.git -c x=y checkout foonow blocks; benigngit -c x=y statusstill passes.mcp-task-manager-servershipped a verbatim GPL-3.0 LICENSE butpackage.jsondeclaredISC(leftovernpm initscaffold default). Reconciled metadata to reality:package.jsonlicense →GPL-3.0-only;THIRD-PARTY-NOTICESentry UNRESOLVED → RESOLVED, documenting the GPL-3.0-only determination + remaining Apache-2.0 incompatibility (Umbrella: Relicense AutoBot to Apache-2.0 #9826). No deletion — keep/remove/isolate decision left to the maintainer.Verification
bash .claude/hooks/block-dangerous-commands_test.sh→ 33 passed, 0 failed (was 27; +6 cases: 4 block forms for the bypass, 2 benign global-opt allow forms).Model Used
Claude Opus 4.8 (general-purpose subagent).