Repository navigation
refactor(frontend): consolidate to single feature-flag convention — remove unused __FEATURE_* defines (#10086) - #10446
Merged
Merged
Conversation
…date to single VITE_FEATURE_ convention (#10086)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
#10086 — two coexisting feature-flag conventions: vite.config build-time
__FEATURE_VOICE__/VNC/BROWSERdefines (opt-out) vs navItems runtimeVITE_FEATURE_*(opt-in). The build-time defines had zero consumers (verifiedgrep).What Changed
__FEATURE_*defines fromvite.config.jsand their declarations fromshims-vue.d.ts. Feature gating now uses the single runtime convention: navItemsVITE_FEATURE_<NAME>+featureDefaultVisible(bug(frontend): navItems featureFlag is dormant — main nav stopped filtering in #8820 but entries still carry flags #9984).Verification
--noEmit→ 0 errors. No remaining references to__FEATURE_*.Model Used
Opus 4.8
Fixes #10086