Repository navigation
feat(connectors): surface Google Drive connector in create API + UI with OAuth connect (#9003) - #10265
Merged
Conversation
…ith OAuth connect (#9003)
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Applied Black, isort, and autoflake to match code-quality checks. Triggered by workflow auto-fix-formatting.yml. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
The
GoogleDriveConnectorbackend (gdrive.py, registered, 19 tests) and the OAuth gate (#10087:oauth_flow.pygoogle provider,get_access_tokenauto-refresh,ConnectorOAuthButton.vue) already existed — but Google Drive was unreachable: not in the create-API allowlist, not in the frontendConnectorType, no modal form, and the OAuth button had no connector to attach to. This wires it end-to-end.What Changed
Backend
gdriveadded to_SUPPORTED_TYPES(create API).CreateConnectorRequest.secret_id(new) — the OAuth flow stores the token bundle viastore_oauthand hands back asecret_id; create attaches it by reference, skips auth-schema validation + re-storing, and marks the connector OAuth-managed._cfg_with_credentials/ new_oauth_full_config— OAuth-managed connectors resolve a fresh access token viaget_access_token()(auto-refresh + rotation, ADR-007 §10) injected into the bearer field, instead ofload(). Direct-token path unchanged.Frontend
'gdrive'in theConnectorTypeunion; Google Drive type card + config form inConnectorConfigModal.vue(source_type, drive_id, folder_id, sync_subfolders, max_file_size_mb) with the reusableConnectorOAuthButton(provider "google") capturing thesecret_id;buildPayloadsends it on create. i18n strings added.Verification
pytest api/knowledge_connectors_create_test.py knowledge/connectors/gdrive_test.py knowledge/connectors/tests/test_credential_store.py→ 43 passed. New create-test provesgdriveis accepted (no 422),secret_idattaches without re-storing, and the token resolves viaget_access_token.ConnectorConfigModal.gdrive.spec.ts(3) +ConnectorOAuthButton.spec.ts(5) pass;vue-tsc --noEmit0 errors.ConnectorRegistry.get_registered_class("gdrive")non-None; modal renders the gdrive card → Connect →createConnector({connector_type:'gdrive', secret_id}).Model Used
Claude Opus 4.8 (1M context)