Repository navigation
bug(backend): Secret ORM model missing workflow_id column added by migration 20260324_017 #9975
Description
Discovered during
Umbrella #9920 data-layer work (#9759 chain repair) — same class of defect as #9899.
Problem
Migration 20260324_017_add_workflow_secret_scope.py adds a nullable workflow_id column (+ ix_secrets_workflow_id index) to the secrets table and documents a workflow scope value, but the Secret ORM model (autobot-backend/models/secret.py) does not declare it. The model's docstring/scope comment also omits the workflow scope.
Impact
- Schemas built from ORM metadata (
create_allin tests/bootstraps) lackworkflow_id, so any code path inserting/selecting workflow-scoped secrets fails against model-built tables. - The model is not a faithful description of the real table — same correctness/maintenance hazard as bug(llc): AgentOrgNode ORM model is out of sync with agent_org_nodes migration columns #9899.
Fix
Add workflow_id: Mapped[str | None] = mapped_column(String(128), nullable=True, index=True) to Secret, matching the migration. Being fixed alongside #9899 (single ORM/migration sync PR).
Part of umbrella #9920.
Activity
fix(backend): sync AgentOrgNode and Secret ORM models with their migr…
github-actions commentedon Jun 11, 2026
PR #9989 (merged to
Dev_new_gui) references this issue with a close keyword.If this issue is fully resolved, close it manually. If work remains, no action is needed.
mrveiss commentedon Jun 11, 2026
Fixed by PR #9989 (merged to Dev_new_gui, squash
712cf1059).Secret.workflow_idadded matching migration 017, plusSecretScope.WORKFLOWand the synced scope comment. Verifiedsecretsschema column-identical between create_all and migrations.