Skip to content

bug(llc/config): config/ package shadows dead llc/config.py — DEFAULT_STREAMING_WATCHDOG_TIMEOUT unreachable, AGENT_API_BASE_URL duplicated #9776

Closed

Description

@mrveiss

Problem (latent bug + dead code)

autobot-backend/llc/config.py (flat module) and autobot-backend/llc/config/__init__.py (package) both exist. When a package and a same-named module coexist in a directory, Python imports the package — so llc/config.py is dead/unreachable.

Consequences:

  • DEFAULT_STREAMING_WATCHDOG_TIMEOUT is defined only in the dead llc/config.py, so it is not importable:
    >>> from llc.config import DEFAULT_STREAMING_WATCHDOG_TIMEOUT
    ImportError: cannot import name 'DEFAULT_STREAMING_WATCHDOG_TIMEOUT' from 'llc.config'
    
    (Currently nothing imports it, so it's latent — but the constant + its env override LLC_STREAMING_WATCHDOG_TIMEOUT are effectively dead.)
  • AGENT_API_BASE_URL is duplicated (defined independently in both files with the same default), so the two can silently drift.
  • config/__init__.py's docstring claims it "re-exports legacy llc/config.py symbols" — it does not; it redefines AGENT_API_BASE_URL and omits DEFAULT_STREAMING_WATCHDOG_TIMEOUT.

Fix

Consolidate into the package and delete the flat module:

  1. Move DEFAULT_STREAMING_WATCHDOG_TIMEOUT (and any other unique symbols) into llc/config/__init__.py.
  2. Delete llc/config.py.
  3. Verify from llc.config import AGENT_API_BASE_URL, DEFAULT_STREAMING_WATCHDOG_TIMEOUT works and grep for any consumers of the watchdog constant.

References

Introduced by GH#8487 (created the config/ package). Discovered during #9622/#9623 (PR #9772) which imports AGENT_API_BASE_URL from this module.

Labels: bug · backend · priority: medium

Activity

  1. mrveiss commented on Jun 9, 2026

    @mrveiss
    OwnerAuthor

    Fixed in PR #9829 (merged to Dev_new_gui).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions