You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(ci): Unit & Integration Tests red — strict vue-tsc type-check errors on Dev_new_gui #9724
The Unit & Integration Tests check fails at its "Run type checking" step (strict vue-tsc) on Dev_new_gui HEAD. Note: the separate vue-tsc-baseline check passes because it compares against a baseline allowlist — strict checking surfaces many real errors the baseline tolerates. Non-required, so it has been quietly red.
Evidence (file:line, from run 27129655530)
src/App.vue(624,7) TS2339 — getSystemStatusAriaLabel does not exist on UseSystemStatusReturn
src/App.vue(851,7) TS2322 — Timeout not assignable to number
src/components/CommandPalette.vue(250,13) TS2339 — setCurrentAgentType does not exist on chat store
Many Icon name union mismatches, e.g. AgentAbstentionBadge.vue(8,11), AdvancedAnalytics.vue(24,16 / 180,24), CodeEvolutionTimeline.vue(52,20 / 187,22) — string/"help-circle" not assignable to the Icon name union (the union is missing many icon names, or components pass names not in it)
src/components/analytics/CodeReviewDashboard.vue — multiple TS18046 ('segment'/'item' is of type unknown) at 229/234/236/237/253/256/257, plus TS2352 (string→number cast) at 239
Proposed Fix
Extend the Icon component name prop type to include the used icon names (or correct the offending usages) — this clears the bulk.
Add getSystemStatusAriaLabel to useSystemStatus return, setCurrentAgentType to the chat store (or fix callers).
Type the unknown segments/items in CodeReviewDashboard.vue.
Once clean, fold strict vue-tsc into the gated path so this can't silently regress.
Closed — merged to Dev_new_gui (PR #10073, commit eb21d7407).
Criteria met:npx vue-tsc --noEmit -p tsconfig.app.json → 0 errors (was 231), verified after rebase onto current Dev_new_gui. eslint on all 137 touched files → 0 errors. Beyond clearing the type errors, 11 real runtime bugs the strict check exposed were fixed (empty-SVG icons across ~25 components, missing chatStore.setCurrentAgentType TypeError, dropped chat session id, etc.).
Discovery filed:#10074 (qrcode imported but missing from package.json — device pairing; shimmed types pending real install). Part of umbrella #9924.
Activity
fix(frontend): strict vue-tsc — 231 → 0 type errors + 11 real runtime…
github-actions commentedon Jun 13, 2026
PR #10073 (merged to
Dev_new_gui) references this issue with a close keyword.If this issue is fully resolved, close it manually. If work remains, no action is needed.
mrveiss commentedon Jun 13, 2026
Closed — merged to Dev_new_gui (PR #10073, commit
eb21d7407).Criteria met:
npx vue-tsc --noEmit -p tsconfig.app.json→ 0 errors (was 231), verified after rebase onto current Dev_new_gui. eslint on all 137 touched files → 0 errors. Beyond clearing the type errors, 11 real runtime bugs the strict check exposed were fixed (empty-SVG icons across ~25 components, missingchatStore.setCurrentAgentTypeTypeError, dropped chat session id, etc.).Discovery filed: #10074 (qrcode imported but missing from package.json — device pairing; shimmed types pending real install). Part of umbrella #9924.
fix(frontend): align knowledge-icon helper tests with #9724 IconName …
fix(frontend): green the unit+integration suite — 89 failures, 3 unca…
ci(gate): run frontend-test on PRs to Dev_new_gui, not only post-merge (
ci(gate): run frontend-test on PRs to Dev_new_gui, not only post-merge (
ci(gate): run frontend-test on PRs to Dev_new_gui, not only post-merge (
fix(i18n): add missing workflow.canvas.loopLabel to all locales (#9724 …
fix(frontend): repair apexcharts 5.14 type errors blocking frontend-t…
ci(frontend): set vue-tsc regression BASELINE 249→0 — guard was tooth…
fix(frontend): repair 2 strict vue-tsc errors under apexcharts 5.14 (#…
fix(llc/tests): repair test-isolation + liveness mock rot (#9995, #9987…
fix(frontend): add missing qrcode dependency; drop temp type shim (#1…