Skip to content

fix(transcriber): resolve parallel-development merge conflicts (MVA-3745) #9664

Closed

Description

@mrveiss

Context

Manually resolve merge conflicts between issue-MVA-2783 (23 commits) and Dev_new_gui transcriber implementations.

Analysis

  • 33 files with conflicts (mostly add/add)
  • Transcriber developed in parallel on both branches
  • Dev_new_gui has orchestrator.py and upload_security.py not in feature branch

Tasks

  1. Create feature comparison matrix
  2. Identify unique features in issue-MVA-2783 not in Dev_new_gui
  3. Cherry-pick unique features to fresh branch from Dev_new_gui
  4. Test each integration
  5. Create PR

Acceptance Criteria

  • Feature comparison documented
  • All unique features integrated
  • Tests passing
  • PR merged to Dev_new_gui

Related

  • Paperclip issue: MVA-3745
  • Related to GH#9612 (transcriber feature merge)

Activity

  1. self-assigned this
    on Jun 5, 2026
  2. mrveiss commented on Jun 8, 2026

    @mrveiss
    OwnerAuthor

    Triage — escalating (not suitable for autonomous batch)

    Reviewed during the bug-batch sweep. This is not a self-contained fix; it is a feature-branch integration that needs human/architectural judgment:

    • The source branch issue-MVA-2783 (23 commits) still exists on origin (21559fa03) and has diverged from Dev_new_gui's transcriber, which has since received substantial independent work — e.g. a509c7c5b (api/transcriber router), fd2c2a1dd (transcript route models), 6036d57ca (editing API), 02585efb0 (export formats DOCX/PDF/SRT/VTT), 58318397a (deleted obsolete api/transcriber.py).
    • The task requires a feature-comparison matrix to decide, per conflicting file, which implementation wins — that is an architecture decision, not a mechanical merge (Core Rule Dev new gui #4: confirm architecture before coding).
    • Parent umbrella GH#9612 is open and owns this integration.

    Recommendation: handle under #9612 as a dedicated, reviewed effort (feature matrix → cherry-pick unique features onto a fresh branch off current Dev_new_gui → per-integration tests). Leaving #9664 open and assigned there. No autonomous changes made.

  3. mrveiss commented on Jun 10, 2026

    @mrveiss
    OwnerAuthor

    Bug sweep 2026-06-10 → TOO-BIG. A 33-file cross-branch transcriber merge-conflict resolution requiring a feature-comparison matrix and per-feature cherry-picks (issue-MVA-2783 vs Dev_new_gui) — design/merge judgment across many files, not a localized bug fix.

  4. mrveiss commented on Jun 11, 2026

    @mrveiss
    OwnerAuthor

    Feature-comparison matrix (Task 1 of this issue) — completed 2026-06-11

    A full read-only comparison of origin/issue-MVA-2783 (23 commits, head 21559fa03) against current Dev_new_gui was performed (git log/diff/show across all transcriber and transcript surfaces, backend + frontend + tests).

    Bottom line

    issue-MVA-2783 contains zero unique features. Every capability on the branch (project/recording CRUD, transcript editing API, speaker merge, notes, SRT/VTT/DOCX/PDF export, KB push + status, streaming AI analysis, the full transcriber Vue component set, the SQLite sidecar DB) is already present in Dev_new_gui — most of it byte-identical or refined.

    Dev_new_gui additionally carries five things the branch never had:

    1. Orchestrator pipeline (transcriber/orchestrator.py) — async FFmpeg → language detect → diarization → transcription → persist
    2. Upload security hardening (transcriber/upload_security.py, security(transcriber): fix arbitrary file read vulnerability in RecordingCreate API #9214) — path-traversal/SSRF defense
    3. Central transcripts API (api/transcripts.py, wiring: api/transcripts.py router is unmounted — mount or delete (from #9851) #9863/feat(backend): mount transcripts router with real storage backing (#9863) #9955) — WS streaming analysis + per-segment KB push over real storage
    4. Extracted composables (useKbStatus enhancement(transcriber/frontend): replace KbPushButton manual polling with useKbStatus() composable #9206, useSseProgress enhancement(transcriber): expand composable test coverage for useSseProgress and useTranscriberApi #9209, useFileDownload enhancement(transcriber/frontend): extract file download blob pattern into useFileDownload() composable #9204)
    5. Far larger test coverage (recordings/projects/extension/pipeline/WS-analysis suites)

    Verdict per the issue's own acceptance criteria

    • "Feature comparison documented" — this comment.
    • "Identify unique features in issue-MVA-2783 not in Dev_new_gui" — none exist.
    • "Cherry-pick unique features" / "Test each integration" / "PR merged" — vacuously satisfied; there is nothing to integrate.

    Recommendation

    Close this issue as superseded: the parallel-development conflict resolved itself through the subsequent Dev_new_gui transcriber work (#9044 → #9955). The issue-MVA-2783 remote branch can be deleted (or archived via tag) — flagging that as the one remaining human call since it discards branch history. Umbrella #9612 should be updated accordingly.

  5. mrveiss commented on Jun 12, 2026

    @mrveiss
    OwnerAuthor

    Closed — superseded (no integration needed)

    The feature-comparison matrix (Task 1, comment above, 2026-06-11) found zero unique features in issue-MVA-2783 — every capability already exists in Dev_new_gui, which additionally carries the orchestrator pipeline, upload security hardening (#9214), the central transcripts API (#9863/#9955), extracted composables, and larger test coverage.

    The remaining human call (branch disposition) was resolved by the 2026-06-09 branch-estate sweep: origin/issue-MVA-2783 was deleted after per-deliverable verification, with full history archived at tag backup/rebase-2026-06-09/issue-MVA-2783 = 21559fa03 (verified identical to the matrix's analyzed head).

    Acceptance criteria: feature comparison documented ✅ · unique features identified (none) ✅ · cherry-pick/test/PR — vacuously satisfied (nothing to integrate) ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions