Skip to content

[MEDIUM] Consolidate _get_ssot_config Functions (Phase 2 of #751) #763

Description

@mrveiss

Overview

Phase 2 continuation of #751. Migrate 6 duplicate _get_ssot_config() functions to use the new ConfigRegistry.

Files to Migrate

  1. src/constants/network_constants.py (~400 lines)
  2. src/constants/redis_constants.py
  3. src/constants/model_constants.py
  4. src/config/compat.py
  5. src/config/manager.py
  6. src/config/defaults.py

Challenge

These files use attribute access patterns like _ssot.redis.host which need conversion to ConfigRegistry.get("redis.host"). Type conversions may also be needed (strings → typed values).

Acceptance Criteria

  • All 6 _get_ssot_config() definitions removed
  • Files use ConfigRegistry for config access
  • All existing tests pass
  • No regression in functionality

Related

Activity

  1. mrveiss commented on Feb 2, 2026

    @mrveiss
    OwnerAuthor

    Implementation Complete ✅

    Phase 2 migration has been completed. All 6 files with duplicate _get_ssot_config() functions have been migrated to use ConfigRegistry.

    Summary of Changes:

    File Usages Migrated Type
    compat.py 7 Module-level constants
    defaults.py 4 Function-local config
    redis_constants.py 4 Class properties
    model_constants.py 10 Class attributes + method
    network_constants.py 45 Class attributes + URLs
    manager.py 2 Instance variables

    Commits:

    1. 17a20e46 - migrate compat.py
    2. 30b65040 - migrate defaults.py
    3. 02eabeeb - migrate redis_constants.py
    4. 73654181 - migrate model_constants.py
    5. 9b0e8098 - migrate network_constants.py
    6. 2d9a92b0 - migrate manager.py

    Test Results:

    • 45/45 config-related tests passing
    • All migrated modules import and function correctly

    PR: #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions