Skip to content

chore(frontend/types): cleanup vue-tsc errors in Storybook stories cluster (~64 errors, #7227 follow-up) #7273

Closed

Description

@mrveiss

Cluster cleanup PR for #7227 (vue-tsc baseline). The Storybook *.stories.ts files account for ~64 of the 250 documented errors.

Affected files (top of cluster)

  • Icon.stories.ts (14 errors — TS2353 unknown property in literal)
  • BaseAlert.stories.ts (7)
  • BaseCard.stories.ts (6)
  • BaseModal.stories.ts (6)
  • BaseTable.stories.ts (5)
  • BaseBadge.stories.ts (5)
  • ChatHeader.stories.ts (5)
  • EmptyState.stories.ts (4)
  • ErrorBoundary.stories.ts (3)
  • MessageStatus.stories.ts, StableLoadingState.stories.ts, ProgressBar.stories.ts, LoadingSpinner.stories.ts, DataTable.stories.ts, BaseInput.stories.ts (1-2 each)

Error pattern

Most are TS2322/TS2353 — story args don't match component prop types. Examples:

BaseBadge.stories.ts(46,5): error TS2322: Type '"secondary"' is not assignable to type '"success" | "warning" | "error" | "info" | "default" | "primary" | undefined'.

This is mechanical — either fix the story args to match prop unions, or fix the component prop type to include the missing value.

Approach

  1. npx vue-tsc --noEmit -p tsconfig.app.json 2>&1 | grep stories.ts to enumerate
  2. For each file: align story args with component props (or add the missing variant to props)
  3. Re-run vue-tsc; baseline should drop ~64
  4. Update .github/workflows/frontend-typecheck-regression.yml BASELINE from 250 to ~186

Why this cluster first

  • Lowest risk: stories are isolated dev tooling, not production code
  • Largest single category that's mechanical (one fix pattern)
  • Each file is independent — can be done in parallel sub-PRs

🤖 Filed during #7227 closure.

Activity

  1. added 2 commits that reference this issue on May 10, 2026
    60c48b8
    2cd93c3
  2. github-actions commented on May 10, 2026

    @github-actions
    Contributor

    PR #7486 (merged to Dev_new_gui) references this issue with a close keyword.

    chore(frontend/types): clear Storybook stories vue-tsc cluster — 64→0 errors (closes #7273)

    If this issue is fully resolved, close it manually. If work remains, no action is needed.

  3. mrveiss commented on May 11, 2026

    @mrveiss
    OwnerAuthor

    ✅ Closed by merged PR #7486 (commit 4fd2e0a04)

    Acceptance Criteria Met:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions