Repository navigation
discovery(test/worker): 2 tests assert on unwrapped shape but worker_node returns {status,message,data} envelope #7154
Description
Discovery during PR (#6987 part 2)
PR fixing the src.* mock path in worker_node_test.py (#6987 part 2) surfaces 2 pre-existing test failures unrelated to the src.* bug.
Failing tests
FAILED test_llm_chat_completion_success
assert 'response' in result
AssertionError: 'response' in {'status': 'success', 'message': 'LLM completion successful.',
'data': {'response': 'Test response'}}
FAILED test_kb_search_success
assert 'results' in result
AssertionError: 'results' in {'status': 'success', 'message': 'KB search successful.',
'data': {'results': [{'content': 'test result'}]}}
worker_node was refactored at some point to wrap responses in a {status, message, data} envelope. The tests still assert on the unwrapped shape. With the Redis mock fixed (#6987), these failures are now visible.
Acceptance criteria
- Update both tests to assert on
result["data"]["response"]/result["data"]["results"] - Verify the response-envelope pattern is consistent across worker_node — file follow-up if some methods return unwrapped (drift surface)
Related
- bug(tests): 48 mock paths target nonexistent 'src.*' package — patches silently no-op #6987 (parent: src.* mocks)
- The src.* fix in part 2 PR — making this rot visible
Activity
fix(test/worker): assert on envelope-wrapped result shape (#7154)
fix(test/worker): assert on envelope-wrapped result shape (#7154) (#7230
github-actions commentedon May 8, 2026
PR #7230 (merged to
Dev_new_gui) references this issue with a close keyword.If this issue is fully resolved, close it manually. If work remains, no action is needed.
mrveiss commentedon May 8, 2026
✅ Closed — implementation merged to Dev_new_gui.
Fix commit: `479a571b5` → squash-merged via PR #7230
Acceptance Criteria:
Wiring verified: N/A — pure test-side change.
Discovery issues filed: none — envelope is consistent across handlers.
feat(tools/lint): pre-commit hook flagging patch("src.*") mock paths (c…
feat(tools/lint): pre-commit hook flagging patch("src.*") mock paths (c…