[Enhancement] Update code-reviewer agent with function decomposition patterns from #560 #568

Summary

Update the code-reviewer agent to enforce the function decomposition patterns and thresholds defined in issue #560.

Related Issues

• Parent: [Refactor] Long Functions Requiring Decomposition - 581 Instances #560 - Long Functions Requiring Decomposition

Changes Required

Add the following to .claude/agents/code-reviewer.md:

1. Function Length Rules

• 50-line threshold: Functions exceeding 50 lines should be flagged for decomposition
• 100-line critical threshold: Functions over 100 lines are HIGH PRIORITY and must be refactored
• 70-99 lines: Medium priority - should be decomposed when touched

2. Decomposition Patterns to Enforce

1. Extract Helper Functions - Break validation, processing, formatting, response into separate functions
2. Extract Strategy Classes - For functions with many conditionals
3. Extract Data Builders - For MCP tool definitions (consider YAML/JSON externalization)

3. Code Review Checks

When reviewing code, the agent should:

• Check function line counts
• Flag violations of thresholds
• Suggest specific decomposition patterns
• Reference [Refactor] Long Functions Requiring Decomposition - 581 Instances #560 patterns in feedback

Acceptance Criteria

• Code-reviewer agent updated with function length thresholds
• Decomposition patterns documented in agent config
• Agent can identify and flag long functions during review

🤖 Generated with Claude Code