Skip to content

[TODO] Category 5: Cleanup/Refactoring (3 items) #205

Closed

Description

@mrveiss

Parent Issue: #75

Description

3 TODO comments related to cleanup and refactoring tasks.

Items

1. ConversationFileManager Injection (Quick Win)

File: backend/api/conversation_files.py:159

TODO: This will be injected when ConversationFileManager is available

Fix: ConversationFileManager now exists - inject it properly

2. Remove Placeholder Code (Quick Win)

File: backend/api/conversation_files.py:340

# TODO: Remove this when ConversationFileManager is integrated

Fix: Remove placeholder code, use actual ConversationFileManager

3. Redis Service Singleton Pattern

File: backend/api/redis_service.py:39

# TODO: Optimize to singleton pattern for production after development complete

Fix: Convert to singleton pattern following HTTPClient pattern

Acceptance Criteria

  • ConversationFileManager properly injected
  • Placeholder code removed
  • Redis service uses singleton pattern
  • TODO comments removed

Priority

Low - Code cleanup

Quick Wins

Items 1 and 2 can likely be fixed together in < 30 minutes

Activity

  1. mrveiss commented on Nov 26, 2025

    @mrveiss
    OwnerAuthor

    Starting work on Issue #205 - Cleanup/Refactoring

  2. mrveiss commented on Nov 26, 2025

    @mrveiss
    OwnerAuthor

    All 3 items completed:

    1. ✅ ConversationFileManager injection - Already completed (TODO no longer exists in file)
    2. ✅ Remove placeholder code - Already completed (TODO no longer exists in file)
    3. ✅ Redis service singleton pattern - Converted get_service_manager() to singleton with:
      • _service_manager global instance
      • _service_manager_started flag for tracking initialization
      • Consistent state (error tracking, status cache) across requests
      • Proper logging for instance creation/startup

    Committed: 65d23b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions