commit-msg hook should reject a subject with no issue reference #17029

Activity

1. mrveiss

   added

   priority: medium

   chorethe regular light workthe regular light work

   on Sep 18, 2026
2. mrveiss

   added this to the v0.9.0 milestone on Sep 18, 2026
3. mrveiss

   added 2 commits that reference this issue on Sep 18, 2026

   chore(hooks): take the root from the hook's working directory, not a …

   ...

   de45407

   docs(hooks): no bypass in the hooks README — only the conforming rout…

   ...

   0114377
4. github-actions commented on Sep 18, 2026

   

   github-actionsbot

   on Sep 18, 2026 – with GitHub Actions

   Contributor

   More actions

   👋 Auto-triage could not confidently classify this issue (no confident signal). Could a maintainer add the appropriate labels (frontend, backend, infrastructure, docs, testing and good-first-issue, intermediate, advanced)?
5. mrveiss

   closed this as completedin #17047on Sep 19, 2026
6. mrveiss commented on Sep 19, 2026

   

   mrveiss

   on Sep 19, 2026

   OwnerAuthor

   More actions

   Post-merge AC verification (vehicle #17047 → f921ee335, PR #17032)

   Verified directly against git show f921ee335:<path> — not inferred from the PR body.

   • Add a subject-format check to tools/git-hooks/commit-msg — implemented not as a duplicated grep but by calling the one existing implementation of the rule: tools/git-hooks/commit-msg (lines ~40-50) runs bash "$lint" --commit-msg "$msg_abs" where lint="$PWD/scripts/lint-conventions.sh", so it cannot drift from lint-commit-subject's own logic. File is tracked and executable (100755). Covered by repo_tests/commit_msg_hook_17029_test.py:57 test_a_conventional_subject_with_an_issue_reference_passes and :66 test_a_subject_off_the_convention_is_rejected.
   • Keep the existing trailer-stripping behaviour unchanged — trailer stripping (Co-authored-by, Claude Code promo line, Claude-Session:) present at the top of the hook, byte-for-byte the same three grep -viE pipeline. repo_tests/commit_msg_hook_17029_test.py:77 test_trailers_are_still_stripped.
   • Update scripts/install-git-hooks.sh doc-comment noting the new behaviour — scripts/install-git-hooks.sh:56: "commit-msg (commit-msg hook should reject a subject with no issue reference #17029) strips co-author trailers and [enforces the subject convention]"; MANAGED_HOOKS="pre-commit pre-push commit-msg" at line 59 (the one logic change needed to actually install it, beyond the doc comment). repo_tests/git_hooks_installer_test.py:38: _MANAGED = ("pre-commit", "pre-push", "commit-msg") — the installer's existing test suite now exercises commit-msg too.

   Additional coverage beyond the stated scope, found during review: the lint script's own exemptions (Merge, Revert, fixup!, squash!, worktree claims) apply through the hook (repo_tests/commit_msg_hook_17029_test.py:73 test_the_lint_scripts_own_exemptions_apply); a checkout without the lint script (an old branch) warns but is not blocked (:88 test_a_checkout_without_the_lint_script_is_not_blocked); and a real git commit with the hook installed is refused then accepted (:95 test_a_real_commit_is_refused_then_accepted).

   All ACs met. Verified against the actual merged head f921ee335 (PR #17047, a multi-PR vehicle), post the ledger's recorded approval — confirming the vehicle's update-branch churn did not drop or corrupt this fix. Leaving closed.