Skip to content

frontend(admin): .checkbox-input class used but never defined, anywhere #16888

Description

@mrveiss

What

`autobot-frontend/src/views/AdminMcpServersView.vue` uses `class="checkbox-input"` on two checkbox inputs (allowed-roles list, enabled toggle). The class is not defined in the view's own `<style scoped>` block, and not in `autobot-frontend/src/assets/css/components.css` (Issue #901's shared component library) either — `grep -rn "checkbox-input" autobot-frontend/src/assets/css/components.css` is zero hits.

Found while fixing two other CSS regressions on PR #16875 (#16825) — this one predates that PR (confirmed present at commit 990aa2f, before the components.css consolidation rewrite), so it's a separate, pre-existing gap, not something that rewrite introduced.

Functionally inert today: an unstyled `type="checkbox"` falls back to the browser's native checkbox rendering, so nothing is visibly broken. Filing because an undefined class on a form control is either a missing style (browser default isn't the intended look) or dead markup (the class should be removed) — worth a decision either way rather than leaving it silently unresolved.

Acceptance criteria

  • Either `.checkbox-input` gets a real rule (locally or in components.css, per whether other admin views need the same checkbox treatment), or the class is removed from the two inputs in `AdminMcpServersView.vue` as dead markup

Activity

  1. mrveiss commented on Sep 21, 2026

    @mrveiss
    OwnerAuthor

    Closure evidence — verified against merged main (6db6ee38d7, PR #17153)

    Auto-closed by the merge; recording the evidence separately, since a merge is not a closure.

    .checkbox-input is now defined in the shared components.css, and its consumer was confirmed rather than assumed: autobot-frontend/src/views/AdminMcpServersView.vue uses class="checkbox-input" and that file carries no local <style> block, so it relied entirely on the shared sheet — which had no such rule before this change. That is the defect this issue reported.

    Non-blocking observation from review, not introduced here: .checkbox-input is still separately declared as component-scoped CSS in four other files — BudgetPolicies.vue, components/base/BaseTable.vue, components/chat/ApprovalRequestCard.vue, components/chat/ChatMessages.vue. They are scoped, so there is no functional conflict with the new shared rule, but it is duplication the reusable-components goal would want consolidated. Pre-existing, not worsened by this PR, and worth a follow-up rather than reopening this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions