Repository navigation
chore(codegen): fold ROLE_RANK into gen_frontend_types.py, matching Permission/Role #16491
Description
Activity
Closure evidence (batch 2c)
Verified against
origin/main(PR #16493, 79c6344). No checkboxes, so the issue's ask is taken as the criteria. All met.Criterion Evidence Codegen emits a typed data constant from a Python dict autobot-infrastructure/shared/scripts/gen_frontend_types.py:142class ConstMap(NamedTuple),:415def _render_const_map; tests inrepo_tests/gen_frontend_types_test.pyROLE_RANKis generated from_ROLE_META, not hand-mirroredgen_frontend_types.py:166ConstMap(..., "_ROLE_META", "ROLE_PRIORITY", "Role", "number", "priority");autobot-frontend/src/constants/roles.ts:61ROLE_RANK ... = ROLE_PRIORITY; testsconstants/__tests__/roles.test.tsexpect(ROLE_RANK).toBe(ROLE_PRIORITY)andgen_frontend_types_test.py::test_const_manifest_emits_the_role_maps_the_frontend_consumesCaveat: the drift check is not required (#16568).
Follow-up from #16243
#16243 extended
autobot-infrastructure/shared/scripts/gen_frontend_types.pytogenerate the
Permissionunion fromautobot_shared/auth/permissions.py, thesame pipeline
Rolealready uses.constants/roles.ts'sROLE_RANK(added by#16244, mirroring
_ROLE_META'spriorityfield) stays hand-maintained fornow -- it's DATA (a
Dict[Role, int]), not a type/enum shape, and the codegenframework's MANIFEST only supports emitting TypeScript from a Python
@dataclassorEnum(seegen_frontend_types.py's own module doc).Ask
Extend the codegen framework to also support emitting a typed data constant
from a Python dict (or add a small, purpose-built second code path) so
ROLE_RANK(and potentially the backend's real_ROLE_METAprioritiesdirectly) can be generated rather than hand-mirrored -- closing the same
silent-drift gap #16243 closed for
Permission.Refs #16243, #16244.