Skip to content

decision(repo): default branch and Actions PR permission — two issues, no code in either #15834

Description

@mrveiss

One decision, two issues

Both are repository settings, not code. No pull request can close either, which is why both have
sat unstarted.

Issue The face it wears
#15318 every scheduled workflow runs main's copy — 500 commits behind Dev_new_gui; seven are stale there and the armed pip-audit gate has never run on current code
#15167 the release workflow cuts the tag, then fails on "Open changelog PR to main" — GitHub Actions is not permitted to create or approve pull requests

The questions

1. Should Dev_new_gui be the default branch? Schedules fire from the default branch. Every PR
already targets Dev_new_gui, and main is 500 commits behind, so today's scheduled security gates
run code nobody ships.

2. May GitHub Actions open pull requests in this repository? The toggle that permits it also
permits Actions to approve PRs, which is why it is off.

Options

Option Consequence
1A (recommended) Make Dev_new_gui the default branch Schedules run what the tree contains. Matches reality. Cost: external links and clones land on Dev_new_gui; main becomes an explicit release pointer
1B Keep main, add explicit branches: to each schedule No default-branch change. Cost: seven workflows to edit and a standing trap for the eighth
2A Enable "Allow GitHub Actions to create and approve pull requests" One setting, no code. Cost: also permits Actions to approve, which weakens any review gate — see the sibling decision on branch protection
2B (recommended) Use a dedicated token (PAT or app) for the changelog step Keeps approval permission off. Cost: a credential to provision and rotate

Recommendation

1A and 2B. 1A because a security gate that has never run on current code is not a gate, and every
other signal in the repository already treats Dev_new_gui as trunk. 2B because 2A trades a review
control for a convenience, and the sibling decision may be about to make that review control real.

What happens to the two

They become dependents. Each closes on the settings change plus a note recording the new state.

Activity

  1. added
    needs-decisionBlocked on an owner decision; options and a recommendation are on the issue
    on Sep 6, 2026
  2. mrveiss commented on Sep 11, 2026

    @mrveiss
    OwnerAuthor

    Question 1 is decided; question 2 is still open, and it now gates the chosen fix.

    Details and the measurement are on #15318.

  3. mrveiss commented on Sep 11, 2026

    @mrveiss
    OwnerAuthor

    Owner decision, 11 Sep 2026, Q2: neither 2A nor 2B. The sync is done by hand. "Allow GitHub Actions to create and approve pull requests" stays off, and no push token is provisioned for this repository. Consequence for #16246 / #16263: the weekly sync-main-to-dev.yml run cannot open the sync PR. The script keeps #13973's behaviour: it warns, links the compare page, and exits 0. The owner opens each weekly sync PR by hand from that link. A PR a person opens starts its checks normally, so the parked-run problem (#16272) does not arise for it. CI_BOT_ATTRIBUTION.md will be corrected to say this. Q1 was decided earlier on #16221 (keep main, sync regularly).

  4. mrveiss commented on Sep 11, 2026

    @mrveiss
    OwnerAuthor

    Owner decision, 2026-09-11, extending the Q2 ruling: the weekly sync check may keep one tracking issue open. It exits 2 when it can't write that issue, so a reminder that fails to post shows as a red scheduled run instead of vanishing (release_sync_main.py:574, #16263).

  5. added this to the Backlog milestone on Sep 12, 2026
  6. mrveiss commented on Sep 20, 2026

    @mrveiss
    OwnerAuthor

    Branch-freeze re-verification against current origin/main (2026-09-20). Both tracked branches (issue-16246-sync-main, issue-16263-track) are already gone from origin.

    Q1 confirmed current: gh api repos/mrveiss/AutoBot-AI --jq '.default_branch' returns main, matching the 2026-09-11 comment's #16221 decision.

    Q2 has two conflicting recorded owner decisions, 7 days apart, and I don't think either should be assumed current without a human resolving it:

    Current live state: gh api repos/mrveiss/AutoBot-AI/actions/permissions/workflow still returns can_approve_pull_request_reviews: false — so as of right now, the 09-11 ruling ("stays off") is what's actually in effect, not the 09-18 intent. That could mean the 09-18 decision simply hasn't been executed yet, or that it supersedes 09-11 and execution is pending, or that I'm reading a stale comment against a decision that was later reconsidered. I can't tell which from the record alone, and it's a repository-administration setting only the owner can change — not something I'll toggle or guess about.

    Flagging this contradiction rather than picking a side. Someone with the full decision history (or the owner directly) should confirm which of the two rulings is current before #15167 is worked further — it changes what "done" looks like for that issue.

  7. mrveiss commented on Oct 3, 2026

    @mrveiss
    OwnerAuthor

    What would have to be true to close this — and tonight's evidence that it is not yet true

    Found by a sweep for umbrellas whose native children are all closed (both of this one's are). It stays open, and there is now direct evidence for why.

    The one thing missing: the Actions PR permission is still off

    Screening #17728 tonight established that the weekly-durations land job fails with "GitHub Actions is not permitted to create or approve pull requests", and no PR has ever existed from it. That is the repository setting Allow GitHub Actions to create and approve pull requests — the permission half of this decision — still unflipped.

    To close: the setting is flipped and a bot-opened PR demonstrably exists from the job that could not create one. That is the artifact; a decision recorded without the setting changed leaves the symptom in place.

    One distinction worth carrying into the flip

    There are two adjacent settings, not one, and they are distinguished by whether a PR exists:

    blocked thing the setting
    this issue / the land job the creation of the PR Allow GitHub Actions to create and approve pull requests
    #17728 the workflows on a PR that was created (#17723, 18 runs action_required) fork-PR approval policy, all_external_contributors

    Flipping the creation setting unblocks land and leaves #17723's runs held. Relaxing the fork policy does the reverse. Two flips, or one flip and a remaining defect — detail on #17728.

    Neither half is verifiable from here: repository settings need admin-visible state I cannot read, so the evidence above is the observable symptom, not the setting value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cidocsneeds-decisionBlocked on an owner decision; options and a recommendation are on the issue

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions