Repository navigation
ci(tooling): mergeStateStatus reads BLOCKED on mergeable PRs — bypass actors are not accounted for #15367
Closed as not planned
Description
Activity
Correction — there is no repo-side code to fix here
Grepped the repository for consumers of
mergeStateStatus/reviewDecision. Two files match,
and both matches are comments, not code:auto-update-pr-branches.yml:166—# #12818: do NOT filter on mergeStateStatus. It is computed LAZILY by [GitHub]— an explicit warning against the exact misuse this issue describes. The
workflow already avoids it.frontend-required-context.yml:23— a comment recording a past incident where
mergeStateStatusreadBLOCKEDwith no failing job.
So the repo already knows this trap and has written it down twice. The consumers that actually
misread landability are outside this repository (the localdrain-parked.shreadiness script,
and agent reasoning), which no PR here can reach.Closing as not-actionable in this repo. The underlying observation stands and is recorded on
#15357 —mergeStateStatus: BLOCKEDis cosmetic here because the ruleset grants the admin role
bypass_mode: always, and GitHub computes that field without accounting for bypass actors — but
the fix belongs in the local tooling, not in a tracked file.
Parent: #15357
Problem
mergeStateStatus: BLOCKEDandreviewDecision: REVIEW_REQUIREDare false signals on thisrepository, and they cost real diagnosis time.
The
Dev_new_guiruleset requires 1 approving review but grantsRepositoryRole 5(admin)bypass_mode: always. GitHub computesmergeStateStatuswithoutaccounting for bypass actors, so a PR that the owner can merge right now still reports
BLOCKED.Proof: #15351, #15349 and #15342 all merged with zero approving reviews.
Consequence: every consumer of
mergeStateStatus— the drain script, review-queue tooling,any agent running the "sweep PRs → review → merge" loop — reads a queue of 5 mergeable PRs as a
jammed queue and goes looking for a blocker that does not exist. This happened during the triage
of #15357 itself.
Fix
Establish one repo-local helper that answers "can this PR actually land?" and have every consumer
use it instead of reading
mergeStateStatusdirectly. It must account for:DIRTY/ conflict states.Audit and convert existing call sites — the drain/readiness script and any workflow or skill that
branches on
mergeStateStatusorreviewDecision.Acceptance Criteria
mergeStateStatus/reviewDecisionfor a landability decision convertedImplementation Order
Wave: 1
Depends on: none
Unblocks: #15357