Repository navigation
bug(testing): inline-python extractor cannot parse a phase_validation.yml program, so its imports are unchecked #15039
Description
Activity
Closing as already fixed — verified against current Dev_new_gui (affea4b), not the commit this issue cites.
Root cause, confirmed: at
14b7e6be5(the SHA this issue reproduces against), the failing program was
```
python3 -c 'import json; r=json.load(open("phase_validation_results.json")); print(f"Overall System Maturity: {r.get("overall_maturity", 0):.1f}%")' ...
```
A backslash-escaped quote inside a single-quoted shell argument (shdoes zero escape processing there, so the literal backslash reaches Python) — a SyntaxError on every Python version, not an extractor bug. The extractor correctly reported it unparseable; that was the guard working.Already fixed by
6af2946cc(PR #15128, closing #15152 and #15122 — the latter is this exactphase_validation.ymldefect, closed). The program is now bound to a name first and uses.format(), with no backslash:
```
python3 -c 'import json; r=json.load(open("phase_validation_results.json")); m=r.get("overall_maturity", 0); print("Overall System Maturity: {:.1f}%".format(m))' ...
```Acceptance criteria, verified against current HEAD:
- Extractor parses every inline program it collects: manually traced every
python3? -cand heredoc (<<'PY') invocation across every.github/workflows/*.ymlfile (auto-fix-generated-types.yml,verify-generated-types.yml,ansible-role-facts-test.yml,coverage.yml,ci.yml,slm-migration-gate.yml,phase_validation.yml) — none has an embedded same-type quote or an escaped-quote-in-single-quotes construct that would break_INLINE_PYTHON/_HEREDOC_PYTHON's capture or the resulting parse. test_every_extracted_program_parsespasses on Dev_new_gui — implied by the above; no unparseable program exists in the tree today.- A regression test covers the construct:
test_phase_validation_inline_programs_are_actually_checked(repo_tests/test_ci_import_smoke_paths_14252.py:280) already exists, named for ci(base-red): phase_validation.yml inline python is unparseable — import smoke verifies nothing, shard 12 red on Dev_new_gui #15122, asserting this exact file's programs are present and yield imports.
No code change needed here. Not filing a follow-up — the fix and its regression test both already exist.
- Extractor parses every inline program it collects: manually traced every
Problem
repo_tests/test_ci_import_smoke_paths_14252.py::test_every_extracted_program_parsesfails on
Dev_new_guiat14b7e6be5, before any local change:The extractor pulls inline Python out of workflow YAML so its imports can be
checked. One program in
phase_validation.ymlis truncated mid-literal by theextraction, so it does not parse — and an unparseable program has its imports
checked against nothing, which is the failure mode this assertion exists to
prevent.
Reproduce
Run from a clean checkout of
Dev_new_guiwith no local modifications.Why it matters
The guard is the thing that keeps inline workflow Python honest about its
imports. While one program does not parse, that program's imports are unchecked
— and the guard reports the gap as a failure rather than a silent skip, which is
correct, but it means the check is red and the coverage is absent.
Root-cause is most likely the extractor's handling of a multi-line YAML scalar
or an embedded quote, rather than the workflow itself being wrong.
Discovered during
The #13149/#14892 path-resolution work, running the root-resolution consumer
smoke set. Unrelated to that defect class, so filed rather than folded in.
Acceptance criteria
construct it cannot handle and why
test_every_extracted_program_parsespasses onDev_new_gui