Repository navigation
fix(events): PersistStrategy.REDIS drops the event instead of writing to the Redis stream #14816
Description
Part of #14815.
Problem
EventBus.publish does not implement its own PersistStrategy.REDIS arm. It logs a critical and
drops the event (autobot-backend/events/bus.py:76-84):
if persist is PersistStrategy.REDIS:
logger.critical("PersistStrategy.REDIS is not implemented in EventBus — event dropped ...")
return
Meanwhile RedisEventStreamManager (autobot-backend/events/stream_manager.py:125) is a fully
built durable event store on Redis Streams — xadd(..., maxlen=config.max_stream_length) (:167),
xrange (:322), get_latest (:262), get_event (:337), get_task_events (:304).
So the durable replay substrate exists and is unreachable through the unified bus. This is the
prerequisite for reconnect-with-replay (#14818).
Scope
- Implement the
PersistStrategy.REDISbranch inEventBus.publishagainst
RedisEventStreamManager, replacing the drop. - Decide and document whether REDIS implies MEMORY fan-out as well (it should — a durable event
that no connected client sees is a regression on today's behaviour). - Update the module docstring's migration plan (
events/bus.py:19-22), which still lists Phase 2
and Phase 3 as outstanding.
Acceptance criteria
-
publish(..., persist=PersistStrategy.REDIS)writes to the Redis stream and reaches
connected subscribers. - No code path in
EventBus.publishdrops an event while logging critical. - Test drives
EventBus.publish(the production entry point) and asserts the event is
readable back viaRedisEventStreamManager, not that a mock was called.
Sources
Parent: #14815 · Full analysis: docs/research/agent-host-and-agent-client-protocols.md
- Agent Host Protocol — Microsoft, MIT — https://microsoft.github.io/agent-host-protocol/ ·
https://github.com/microsoft/agent-host-protocol - Agent Client Protocol — Zed + JetBrains, Apache-2.0 —
https://agentclientprotocol.com/get-started/introduction ·
https://github.com/zed-industries/agent-client-protocol
Activity
mrveiss commentedon Aug 22, 2026
Audit trail and full analysis: #14826 —
docs/research/agent-host-and-agent-client-protocols.md.Sources for this finding:
fix(events): fan out WebSocket broadcast per connection and decouple …
feat(events): multi-client session synchronization, replay and an ACP…
mrveiss commentedon Aug 23, 2026
Delivered and merged.
events/bus.py: thePersistStrategy.REDISarm publishes durably instead of logging critical and returning. It fans out to the channel as well — a persisted event no client sees would have regressed prior behaviour.Tests:
events/bus_channel_fanout_14822_test.py(4).Evidence
ded8d07e7intoDev_new_gui889e3ac4a: 57 passed / 0 failed / 0 cancelled / 0 pendingcode-reviewerpass run before merge; all 3 findings fixed in-PR with regression testsorigin/Dev_new_guiafter mergeNot verified on a host. The tests above exercise the seams, but no running instance has confirmed the end-to-end behaviour (a second tab receiving events, a reconnect replaying the gap). If that matters for this issue, reopen against a deployed check.
Closing by hand:
Closes #Ndoes not fire here, since the PR targetedDev_new_guirather than the default branch.