Skip to content

refactor(frontend): #12363 Phase 1 — last 2 clients onto canonical ApiClient #12582

Closed

Description

@mrveiss

Context

Discrete sub-issue for Phase 1 of #12363 (single-transport guarantee for the frontend HTTP clients). A prior effort (#12152) already routed 6 of 8 clients through the canonical `utils/ApiClient.ts`. This phase finishes the transport half by migrating the last 2 outliers.

Scope (behaviour-neutral)

  • `utils/AdvancedControlApiClient.ts` — swap `fetchWithAuth` for `apiClient.rawRequest` (single-shot; no retry/401-auto-logout change), mirroring the `VisionMultimodalApiClient`/`FeatureFlagsApiClient` thin-wrapper pattern.
  • `utils/SecretsApiClient.js` (+ `.d.ts`) — convert to a single typed `SecretsApiClient.ts`, identical behaviour and import surface.

Out of scope (later phases of #12363)

  • Phase 2: raw-fetch retirement
  • Phase 3: generated-type adoption
  • Owner decision: whether AdvancedControl/Secrets should inherit retry + 401-auto-logout (would be a behaviour change).

Refs #12363

Activity

  1. mrveiss commented on Jul 26, 2026

    @mrveiss
    OwnerAuthor

    Delivered by #12583 (merged): AdvancedControlApiClient migrated from fetchWithAuth to apiClient.rawRequest (single-shot, behavior-neutral) and SecretsApiClient.js→.ts. All 8 frontend clients now route through the canonical ApiClient. 22 tests + vue-tsc clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions